From 480803d5baa8414e13588d10f7ca694eb5eec433 Mon Sep 17 00:00:00 2001 From: Matthias Clasen Date: Thu, 8 Jun 2006 17:01:28 +0000 Subject: [PATCH] Don't include gtkprinter-private.h here. 2006-06-08 Matthias Clasen * gtk/gtkprintbackend.h: Don't include gtkprinter-private.h here. * gtk/gtkprintunixdialog.c: * gtk/gtkprintoperation-unix.c: * gtk/gtkprintjob.c: * gtk/gtkprintbackend.c: Instead include it here. * gtk/gtk.symbols: * gtk/gtkprintoperation.h: * gtk/gtkprintoperation.c: Rename pdf_target to export_filename. --- ChangeLog | 7 +++++++ ChangeLog.pre-2-10 | 7 +++++++ gtk/gtkprintbackend.c | 1 + gtk/gtkprintbackend.h | 3 +-- gtk/gtkprintjob.c | 1 + gtk/gtkprintoperation-unix.c | 1 + gtk/gtkprintoperation.c | 14 ++++++++------ gtk/gtkprintoperation.h | 3 ++- gtk/gtkprintunixdialog.c | 1 + 9 files changed, 29 insertions(+), 9 deletions(-) diff --git a/ChangeLog b/ChangeLog index 032187d024..8189bd3a5d 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,5 +1,12 @@ 2006-06-08 Matthias Clasen + * gtk/gtkprintbackend.h: Don't include gtkprinter-private.h here. + + * gtk/gtkprintunixdialog.c: + * gtk/gtkprintoperation-unix.c: + * gtk/gtkprintjob.c: + * gtk/gtkprintbackend.c: Instead include it here. + * gtk/gtk.symbols: * gtk/gtkprintoperation.h: * gtk/gtkprintoperation.c: Rename pdf_target to export_filename. diff --git a/ChangeLog.pre-2-10 b/ChangeLog.pre-2-10 index 032187d024..8189bd3a5d 100644 --- a/ChangeLog.pre-2-10 +++ b/ChangeLog.pre-2-10 @@ -1,5 +1,12 @@ 2006-06-08 Matthias Clasen + * gtk/gtkprintbackend.h: Don't include gtkprinter-private.h here. + + * gtk/gtkprintunixdialog.c: + * gtk/gtkprintoperation-unix.c: + * gtk/gtkprintjob.c: + * gtk/gtkprintbackend.c: Instead include it here. + * gtk/gtk.symbols: * gtk/gtkprintoperation.h: * gtk/gtkprintoperation.c: Rename pdf_target to export_filename. diff --git a/gtk/gtkprintbackend.c b/gtk/gtkprintbackend.c index 1a139deb52..aa6c38cad5 100644 --- a/gtk/gtkprintbackend.c +++ b/gtk/gtkprintbackend.c @@ -27,6 +27,7 @@ #include "gtkmodules.h" #include "gtkprivate.h" #include "gtkprintbackend.h" +#include "gtkprinter-private.h" #include "gtkalias.h" #define GTK_PRINT_BACKEND_GET_PRIVATE(o) \ diff --git a/gtk/gtkprintbackend.h b/gtk/gtkprintbackend.h index e8d9711ea8..21419095f7 100644 --- a/gtk/gtkprintbackend.h +++ b/gtk/gtkprintbackend.h @@ -32,9 +32,8 @@ #include #include -#include "gtkprinter-private.h" #include "gtkprintsettings.h" -#include "gtkprinteroption.h" +#include "gtkprinteroptionset.h" #include "gtkprintjob.h" G_BEGIN_DECLS diff --git a/gtk/gtkprintjob.c b/gtk/gtkprintjob.c index adc385e148..2781c996ca 100644 --- a/gtk/gtkprintjob.c +++ b/gtk/gtkprintjob.c @@ -35,6 +35,7 @@ #include "gtkprintjob.h" #include "gtkprinter.h" +#include "gtkprinter-private.h" #include "gtkprintbackend.h" #include "gtkalias.h" diff --git a/gtk/gtkprintoperation-unix.c b/gtk/gtkprintoperation-unix.c index e73964076a..4eb81c097b 100644 --- a/gtk/gtkprintoperation-unix.c +++ b/gtk/gtkprintoperation-unix.c @@ -39,6 +39,7 @@ #include "gtkpagesetupunixdialog.h" #include "gtkprintbackend.h" #include "gtkprinter.h" +#include "gtkprinter-private.h" #include "gtkprintjob.h" #include "gtklabel.h" #include "gtkalias.h" diff --git a/gtk/gtkprintoperation.c b/gtk/gtkprintoperation.c index ebf377e454..c54dedd5ce 100644 --- a/gtk/gtkprintoperation.c +++ b/gtk/gtkprintoperation.c @@ -2268,22 +2268,24 @@ print_pages (GtkPrintOperation *op, /** * gtk_print_operation_get_error: * @op: a #GtkPrintOperation + * @error: return location for the error * * Call this when the result of a print operation is * %GTK_PRINT_OPERATION_RESULT_ERROR, either as returned by * gtk_print_operation_run(), or in the ::done signal handler. * The returned #GError will contain more details on what went wrong. * - * Return value: a #GError representing the error, or #NULL - * * Since: 2.10 **/ -GError * -gtk_print_operation_get_error (GtkPrintOperation *op) +void +gtk_print_operation_get_error (GtkPrintOperation *op, + GError **error) { - g_return_val_if_fail (GTK_IS_PRINT_OPERATION (op), NULL); + g_return_if_fail (GTK_IS_PRINT_OPERATION (op)); - return op->priv->error; + g_propagate_error (error, op->priv->error); + + op->priv->error = NULL; } diff --git a/gtk/gtkprintoperation.h b/gtk/gtkprintoperation.h index 6f7a4d17a8..abbb1525d0 100644 --- a/gtk/gtkprintoperation.h +++ b/gtk/gtkprintoperation.h @@ -162,7 +162,8 @@ GtkPrintOperationResult gtk_print_operation_run (GtkPrintOper GtkPrintOperationAction action, GtkWindow *parent, GError **error); -GError * gtk_print_operation_get_error (GtkPrintOperation *op); +void gtk_print_operation_get_error (GtkPrintOperation *op, + GError **error); GtkPrintStatus gtk_print_operation_get_status (GtkPrintOperation *op); G_CONST_RETURN gchar * gtk_print_operation_get_status_string (GtkPrintOperation *op); gboolean gtk_print_operation_is_finished (GtkPrintOperation *op); diff --git a/gtk/gtkprintunixdialog.c b/gtk/gtkprintunixdialog.c index c6ebc21134..3f2e521050 100644 --- a/gtk/gtkprintunixdialog.c +++ b/gtk/gtkprintunixdialog.c @@ -47,6 +47,7 @@ #include "gtklabel.h" #include "gtkprintbackend.h" +#include "gtkprinter-private.h" #include "gtkprintunixdialog.h" #include "gtkprinteroptionwidget.h" #include "gtkalias.h" -- 2.30.2